Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python benchmark script #903

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thevishalagarwal
Copy link
Contributor

  • fixed warmup generation loop to complete the generation of tokens instead of generating just one token
  • removed redundant generator object initialization in the benchmark loop. This improves (reduces) memory utilization
  • fixed things related to printing memory usage

Issue: If multiple prompt lengths are used in benchmark arg, the script would print the same memory usage for all cases.
Solution: Need to reset monitoring and peak_gpu_memory variables in each benchmark loop and print at the end of the loop along with other metrics

@thevishalagarwal
Copy link
Contributor Author

@baijumeswani to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant